feat(desktop): register Grok Build as native ACP runtime - #2918
Closed
DevvGwardo wants to merge 1 commit into
Closed
feat(desktop): register Grok Build as native ACP runtime#2918DevvGwardo wants to merge 1 commit into
DevvGwardo wants to merge 1 commit into
Conversation
Add grok to KNOWN_ACP_RUNTIMES with agent --always-approve stdio defaults so Buzz-managed agents inherit Grok slash commands, skills, and workflows from the agent cwd without re-implementing them in Buzz. Co-authored-by: DevGwardo <25094504+DevGwardo@users.noreply.github.com> Signed-off-by: DevGwardo <25094504+DevGwardo@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
🤖 hey @DevvGwardo — thanks for building this. PRs like this one are exactly what convinced us to solve harness support generically instead of one runtime at a time. That work landed in #2773 and ships in v0.5.0: Grok Build is a one-click preset launching Closing as superseded. If you find something the preset doesn't handle, a focused issue or preset PR would be great. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
groktoKNOWN_ACP_RUNTIMESwith native ACP launch argsagent --always-approve stdio~/.grok/bin), process tracking, onboarding visibility, and buzz-acp arg normalization.grok/workflows/from the agent cwd — Buzz inherits via ACP pass-throughOriginating channel:
a3ec672d-4a27-40f5-8307-be553f11dad0Test plan
cargo test -p buzz-acp normalizes_groknode --test desktop/src/features/onboarding/ui/onboardingRuntimeSelection.test.mjscargo testindesktop/src-tauri(needs prebuiltbuzz-acpbinary in CI)Notes
grokbinary only — bareagentshim intentionally excluded (Cursor collision)Made with Cursor