Skip to content

fix(messages): restore main typecheck for pasted mentions - #684

Merged
wesbillman merged 1 commit into
mainfrom
larry/fix-main-mention-candidates
Oct 6, 2026
Merged

wesbillman merged 1 commit into
mainfrom
larry/fix-main-mention-candidates

Conversation

@loganj

@loganj loganj commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🤖

Summary

  • Main does not build. Two pull requests merged within minutes of each other and each was correct alone: feat(messages): copy and paste mentions, channel refs and links #579 (paste mentions) checked pasted identity links with a helper that refactor(mentions): let the Mentions plugin own what the chooser offers #669 (Mentions plugin owns the chooser) moved out of the app shell. TypeScript now fails in MessageComposer.tsx.
  • This change restores the build without changing what users see. When you paste a link to a person, the composer still notifies them under their current profile name, never the pasted label. A key with no known name stays plain text unless that person is in the channel. Edits still never add recipients.

Details

#579 added pasted identity links using mentionCandidates, which #669
moved into the Mentions plugin. Main no longer typechecks. The host now
names a pasted recipient through mention-admission, keeping #579's
behaviour: current names only, and an unknown outsider stays display-only.

Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
@wesbillman
wesbillman marked this pull request as ready for review October 6, 2026 23:54
@wesbillman
wesbillman requested review from a team, comp615 and wesbillman as code owners October 6, 2026 23:54
@wesbillman
wesbillman merged commit b03be61 into main Oct 6, 2026
22 checks passed
@wesbillman
wesbillman deleted the larry/fix-main-mention-candidates branch October 6, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants