Skip to content

List remote agents in the Builderlab integration - #634

Merged
jsibbison-square merged 1 commit into
mainfrom
jsib-261006-builderlab-list-agents
Oct 6, 2026
Merged

jsibbison-square merged 1 commit into
mainfrom
jsib-261006-builderlab-list-agents

Conversation

@jsibbison-square

@jsibbison-square jsibbison-square commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Shows the signed-in user's Builderlab remote agents in Settings → Integrations -> Builderlab, including names, public keys and status. Just a raw list of agents to be better designed in future.

Listing reuses the existing OAuth session and native host HTTP, with loading, empty, refresh/retry and session-expiry handling; sign-out and navigation discard late results. Agent creation stays on the separate stacked branch.

Validation:

  • Pre-push passed: TypeScript, 100 related tests across 12 files, design types and guards. Focused Builderlab tests (66 cases), Biome and native debug build also passed.
  • Agent exercised automatic login, listing and refresh in the desktop app; User confirmed manual testing.
  • Independent agent review found no blockers. Tests use example domains, with protocol coverage in the client, lifecycle/recovery in mounted components, and shared-session/native attribution in plugin wiring. Retained owner tests caught deliberate callback and credential-header regressions.
  • No browser journeys added or removed. Broad CI and cross-platform validation remain deferred to hosted checks.

Signed-off-by: Jarrod Sibbison <jsibbison@squareup.com>
@torstenrudolf

Copy link
Copy Markdown

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T02:27:16.727616Z 8f30f0d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

}>;

function resultStatus(value: unknown) {
return typeof value === "string"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a beauty

const status = String(value ?? "")
.split("_")
.at(-1);
if (status === "2" || status === "ACTIVE") return "Active";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it doing this mingled status parsing?

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f30f0df8f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sign-out, and disposal.
- `login/` owns the login experience: pending state, cancellation, retry, email
display, and sign-out.
- `agents/` lists the signed-in account's remote agents beneath login. Requests

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DCO sign-off

Commit d505d094d7c1cce8f1f18f56c1a84130604c87cc has no Signed-off-by trailer, so it violates the repository's per-commit DCO requirement and will not satisfy the hosted DCO check. Re-sign the commit using the verified effective author identity while preserving its actual authorship.

AGENTS.md reference: AGENTS.md:L151-L160

Useful? React with 👍 / 👎.

@jsibbison-square

Copy link
Copy Markdown
Contributor Author

will address as follow ups.

@jsibbison-square
jsibbison-square merged commit b287b92 into main Oct 6, 2026
39 of 41 checks passed
@jsibbison-square
jsibbison-square deleted the jsib-261006-builderlab-list-agents branch October 6, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants