Skip to content

fix(windows): integrate window controls into the app header - #633

Closed
wesbillman wants to merge 4 commits into
block:mainfrom
wesbillman:windows-window-chrome
Closed

wesbillman wants to merge 4 commits into
block:mainfrom
wesbillman:windows-window-chrome

Conversation

@wesbillman

Copy link
Copy Markdown
Collaborator

Summary

Extend the integrated window controls to Windows, keeping minimize, maximize/restore, and close in the Buzz header rather than a separate native title bar.

  • Add an undecorated Windows window configuration and share the existing controls between Linux and Windows, including during identity setup.
  • Extend the main-local-webview capability to Windows; keep web and macOS outside the integrated-controls path.
  • Expand component coverage for Windows platform detection, keyboard actions, retry after failure, and controls remaining available during identity restoration.

Relationship to the Linux PR

This branch builds on the Linux implementation in #631. Its diff against main currently includes that prerequisite. The Windows-specific change is commit 22958cb0326e9507b4120edbeed9517dc88f1e5e. Coordinate merge order with #631 and refresh this branch after the Linux change lands; these are not independent competing implementations.

Screenshots

Windows before/after captures are pending. The only images supplied in this branch were the inherited Linux screenshots, already attached to #631. Those are not Windows evidence and are not relabeled here. Both review-only image files have been removed from this PR's final source diff. Windows captures should be attached directly to this description, not committed.

Validation

Current head: 2bd67ca9ebcef2f51e2914868b3982873e720e53. The cleanup commit removes only the two inherited PNGs; application code remains unchanged from the supplied Windows branch.

  • git diff --check passes against upstream aa10599d43077b92f43655fe035e1bc0ae5e6afb.
  • Required local gates passed on macOS at the clean current head: TypeScript, 39 hook-selected related unit tests in 7 files, design-system types/guards, and workspace Clippy. This is not a full test-suite or native Windows run.
  • No browser cases were added or removed. Component tests cover dispatch and accessible controls, not native window-manager behavior. Hosted CI and review remain pending; automatic CI is Linux-only, so it does not establish Windows acceptance.

Before marking ready

  • Attach genuine Windows before/after screenshots.
  • Complete review, hosted CI, and the repository's on-demand Windows native validation.
  • Exercise Windows header dragging/double-click, minimize, maximize/restore, close, edge resizing, and snapping, including at minimum window size and during identity setup.
  • Confirm Linux controls and macOS behavior remain unchanged.
  • Human testing confirmation; reconcile with fix(desktop): integrate Linux and Windows window controls #631 before merge.

Goose Test and others added 2 commits October 3, 2026 22:05
Signed-off-by: Goose Test <d477c5b7260e401b86eed3373fb5f8222dade6eddc9ecde72aba8cd2ff9f434b@wes.communities.buzz.xyz>
Signed-off-by: Codex <noreply@openai.com>
@wesbillman
wesbillman marked this pull request as ready for review October 6, 2026 01:49
@wesbillman
wesbillman requested review from a team and comp615 as code owners October 6, 2026 01:49
@wesbillman

Copy link
Copy Markdown
Collaborator Author

Superseded by #631. The complete Windows branch is preserved as a parent of combined head 3adace1, verified pushed to the existing linux-window-chrome PR branch. #631 includes the shared startup-control repair and retains the outstanding Windows screenshots, native validation and human acceptance checklist. No branch deletion or history rewrite.

@wesbillman wesbillman closed this Oct 6, 2026
codex and others added 2 commits October 6, 2026 00:32
Signed-off-by: Codex <noreply@openai.com>
Signed-off-by: Carl <32a2e2c9d428ee08902cab75d956da2c1d235a22d4766b0dd4138bf6e2e5db1d@buzz.block.builderlab.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants