Repository navigation
fix(testkit): give the board restore time and reject a nameless user - #43
Merged
Merged
Conversation
Restoring the kiosk ran daemon-reload and a restart under a 30 s limit. On busy-screen.local that took 43 s, so a restore that had worked warned that the board did not answer. The limit is now 120 s, above the kiosk unit's 90 s stop timeout.
with_user counted only entries that had a name:, so a second, nameless entry passed and the sample kept a user it never renamed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two testkit fixes found while verifying both apps on the library.
board.Session.restorewaited 30 s; the restore command takes 43 s on busy-screen.local, so a restore that had worked warned that the board did not answer. The limit is now 120 s, above the kiosk unit's 90 s stop timeout.device_file.with_userpassed a second user entry that had noname:line. It now raises.docs/testing.mdrecords the 2026-10-04 board run of both apps.make test-tier0: 735 passed, 3 skipped.