[PM-28227] fix: Keep keyboard alive in autofillText mode via SwiftUI @FocusState anchor#2599
Draft
[PM-28227] fix: Keep keyboard alive in autofillText mode via SwiftUI @FocusState anchor#2599
Conversation
…locking, but not on search.
…chor in a workaround. Replace the UIKit `KeyboardAnchorTextField.becomeFirstResponder()` call on Cancel with a hidden SwiftUI `TextField` bound to a `@FocusState` enum. UIKit's explicit `becomeFirstResponder()` produces `fromBecomeFirstResponder:1` → `delayEndInputSession:YES`, starting a ~5-second RTI countdown that dismisses the extension. SwiftUI's focus machinery uses `fromBecomeFirstResponder:0` → `delayEndInputSession:NO`, keeping the keyboard panel alive indefinitely.
github-actions
Bot
added
app:password-manager
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2599 +/- ##
==========================================
- Coverage 87.20% 87.15% -0.06%
==========================================
Files 1894 1895 +1
Lines 167519 167838 +319
==========================================
+ Hits 146087 146279 +192
- Misses 21432 21559 +127 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-28227
📔 Objective
Fixes the
autofillTextmode keyboard being dismissed (and the extension closing ~5 seconds later) when the user cancels an inline vault search.In
autofillTextmode the extension is shown as a keyboard panel (InputUI) backed by a Remote Text Input (RTI) session. Any text field that becomes first responder via UIKit's explicitbecomeFirstResponder()causes the RTI system to tag the session withdelayEndInputSession:YES(fromBecomeFirstResponder:1), starting a ~5-second countdown that tears down the keyboard panel and dismisses the extension when it fires.The previous approach used a UIKit
KeyboardAnchorTextFieldand calledbecomeFirstResponder()on it when the search Cancel button was tapped — triggering exactly that timer. This PR replaces that path with a hidden SwiftUITextFieldbound to a@FocusStateenum (FocusableField.anchor / .search). SwiftUI's internal focus machinery usesfromBecomeFirstResponder:0→delayEndInputSession:NO, so every focus handoff (including Cancel → anchor) is a clean RTI session continuation with no countdown timer.As a secondary fix,
.searchable/UISearchControlleris replaced with a custom inline search bar inautofillTextmode, sinceUISearchControlleralso calls explicitbecomeFirstResponder()on resign.📸 Screenshots
N/A — keyboard extension panel behaviour, no visual UI change.