Repository navigation
Create the swap pantry only when an element moves into it - #4233
Draft
oliverhaas wants to merge 1 commit into
Draft
oliverhaas wants to merge 1 commit into
oliverhaas wants to merge 1 commit into
Conversation
htmx 4 inserted the pantry after <body> on every swap, and a second one on every morph, even when nothing moved into it. In Chrome that can restyle the whole page. Like htmx 2, create it only when an element moves into it. Refs bigskysoftware#4232
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
htmx 4 inserted the pantry after
<body>on every swap, and a second one on every morph, even when nothing moved into it. In Chrome that can restyle the whole page. Like htmx 2, create it only when an element moves into it.Corresponding issue: #4232
Testing
See repro in #4232. I also added tests: an
hx-preserveswap and a morph that move nothing don't add a pantry anymore (both fail onfour-dev), and a preserving swap removes its pantry again.Checklist
masterfor website changes,devforsource changes) [Assumed
four-devis fine]approved via an issue [No. I hope this is fine just to illustrate what I mean. Feel free to close or replace.]
npm run test) and verified that it succeeded