Repository navigation
chore(deps): move to bgpkit-commons 0.14 - #7
Merged
Merged
Conversation
commons 0.14.1 depends on oneio 0.27, so the crate resolves a single oneio version instead of 0.20 through commons and 0.27 directly. The new commons deprecates the boolean-argument `load_asinfo` loader, so the three call sites build an `AsInfoBuilder` explicitly. `AsInfo` also gained `delegated`, `allocation_status` and `irr`; the two test fixtures set them explicitly, which keeps the generated CSV at its existing width because the row mapper does not read those fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commons 0.14.1 depends on oneio 0.27, so the crate resolves a single oneio version instead of 0.20 through commons and 0.27 directly.
Changes
bgpkit-commons0.9.6 to 0.14.load_asinfoloader is deprecated there, so the three call sites build anAsInfoBuilderexplicitly with the same flags as before.AsInfogaineddelegated,allocation_statusandirr. The two test fixtures set them explicitly; the CSV row mapper does not read them, so the output width is unchanged.allocation_status(always serialized) and keepsdelegated/irrout while they are unset.Testing
cargo fmt --checkcargo clippy --all-targets -- -D warningscargo test(9 tests pass)cargo build --release