Raised by the local cross-family review of LibreChat-AI#16551 (finding local:846b9aa:L-001).
The allSubscribersLeft partial save in api/server/controllers/agents/request.js reads the job record, checks isSettledJobRecord, then calls saveMessage with unfinished: true, error: false. A completion, error or abort path that settles the same response between that read and the write is overwritten by the stale snapshot, so the turn reopens as unfinished on reload.
The window predates LibreChat-AI#16551: on dev the disconnect save has no settled check at all, and LibreChat-AI#16551 narrows it to the settling path's own commit span. Closing it needs the write itself to be conditional (an upsert that refuses to replace a row that is no longer unfinished, or a job-epoch claim taken atomically with the save), which is a storage contract change in packages/data-schemas rather than part of the compaction abort fix.
Expected: a disconnect snapshot never replaces a row a terminal writer already settled.
Raised by the local cross-family review of LibreChat-AI#16551 (finding local:846b9aa:L-001).
The
allSubscribersLeftpartial save inapi/server/controllers/agents/request.jsreads the job record, checksisSettledJobRecord, then callssaveMessagewithunfinished: true, error: false. A completion, error or abort path that settles the same response between that read and the write is overwritten by the stale snapshot, so the turn reopens as unfinished on reload.The window predates LibreChat-AI#16551: on
devthe disconnect save has no settled check at all, and LibreChat-AI#16551 narrows it to the settling path's own commit span. Closing it needs the write itself to be conditional (an upsert that refuses to replace a row that is no longerunfinished, or a job-epoch claim taken atomically with the save), which is a storage contract change inpackages/data-schemasrather than part of the compaction abort fix.Expected: a disconnect snapshot never replaces a row a terminal writer already settled.