fix(ui): prevent text overflow in vertical bar#4
Merged
Conversation
1bd48a4 to
c753afa
Compare
Owner
|
Thanks for the PR, i will review it tomorrow. Cya. @arqueon |
Owner
|
Thanks @arqueon — reviewed and tested locally against current Verdict: accepting. Notes from the review:
Merging now — thanks for the contribution! |
bernardopg
added a commit
that referenced
this pull request
Jun 12, 2026
Follow-up to #4: the 20x20 Canvas ring was duplicated verbatim in the horizontal and vertical pill variants, and read root.heroAccent directly while declaring an unused accent property. Extract it into an inline PillProgressRing component driven by its own percent/accent properties, and record the #4 changes in the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the widget is placed in a vertical panel, the text pill (which originally rendered as
ProviderName 85%) was too wide and caused horizontal overflow. This PR simplifies the vertical bar text to only show the numeric percentage (e.g.,85%), relying on the pill's background color to identify the provider. This ensures a clean layout in vertical environments.