Skip to content

fix(ui): prevent text overflow in vertical bar#4

Merged
bernardopg merged 5 commits into
bernardopg:mainfrom
arqueon:fix-vertical-bar-overflow
Jun 12, 2026
Merged

fix(ui): prevent text overflow in vertical bar#4
bernardopg merged 5 commits into
bernardopg:mainfrom
arqueon:fix-vertical-bar-overflow

Conversation

@arqueon

@arqueon arqueon commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

When the widget is placed in a vertical panel, the text pill (which originally rendered as ProviderName 85%) was too wide and caused horizontal overflow. This PR simplifies the vertical bar text to only show the numeric percentage (e.g., 85%), relying on the pill's background color to identify the provider. This ensures a clean layout in vertical environments.

@arqueon arqueon force-pushed the fix-vertical-bar-overflow branch from 1bd48a4 to c753afa Compare June 11, 2026 20:25
@bernardopg

Copy link
Copy Markdown
Owner

Thanks for the PR, i will review it tomorrow. Cya. @arqueon

@bernardopg

Copy link
Copy Markdown
Owner

Thanks @arqueon — reviewed and tested locally against current main (v1.4.1 + the new docs): qmllint clean, plugin reloads fine, and the horizontal pill renders correctly with the new progress ring.

Verdict: accepting. Notes from the review:

  1. Core fix (vertical pill → percent-only) is right; ProviderName NN% indeed overflows narrow vertical bars, and severity stays readable through the ring color (heroAccent is usage-based) while the accent color identifies the provider.
  2. The PR also changes hero-provider selection to prefer pinned providers and recolors the horizontal dot by provider accent — slightly beyond the title's scope, but both are coherent with the identity-via-color approach, so they're going in as-is.
  3. The 20×20 Canvas ring block is duplicated verbatim in both pill variants, and its accent property is declared but onPaint reads root.heroAccent directly. I'll dedupe it into a shared inline component in a follow-up commit right after merging, so no action needed on your side.

Merging now — thanks for the contribution!

@bernardopg bernardopg merged commit 34134ff into bernardopg:main Jun 12, 2026
bernardopg added a commit that referenced this pull request Jun 12, 2026
Follow-up to #4: the 20x20 Canvas ring was duplicated verbatim in
the horizontal and vertical pill variants, and read root.heroAccent
directly while declaring an unused accent property. Extract it into
an inline PillProgressRing component driven by its own
percent/accent properties, and record the #4 changes in the
changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants