Windows cleanup#517
Conversation
|
You are correct about this on Reason about the "strange" and "should really fail" part: So actually in the windows build log, the issue you proposed has already shown, currently they show as warning, check the latest windows log, there are: D:\a\abc\abc\src\base\main\mainUtils.c(103,11): warning C4013: 'isatty' undefined; assuming extern returning int [D:\a\abc\abc\abclib.vcxproj]
...
D:\a\abc\abc\src\sat\kissat\colors.c(16,35): warning C4013: '_isatty' undefined; assuming extern returning int [D:\a\abc\abc\abclib.vcxproj]
...
D:\a\abc\abc\src\sat\kissat\file.c(37,7): warning C4013: '_access' undefined; assuming extern returning int [D:\a\abc\abc\abclib.vcxproj]
...
D:\a\abc\abc\src\sat\kissat\file.c(60,20): warning C4013: 'S_ISDIR' undefined; assuming extern returning int [D:\a\abc\abc\abclib.vcxproj]
...But I assume all of these could be found by UCRT , which the linker actually search (in the log, we have |
|
Thank you @wjrforcyber for taking a look. Have set |
While working on making ABC build with CMake under yosys environment, noticed these couple of issues.
Very strange is that it builds currently on CI but it should really fail with missing io.h and some of defines.
There was also linking issue related to Abc_TtCanonicizeCA (due to namespace) so added that to .h as other calls and cleaned unneeded extern now.