Skip to content

Windows cleanup#517

Open
mmicko wants to merge 3 commits into
berkeley-abc:masterfrom
YosysHQ:cmake_windows
Open

Windows cleanup#517
mmicko wants to merge 3 commits into
berkeley-abc:masterfrom
YosysHQ:cmake_windows

Conversation

@mmicko

@mmicko mmicko commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

While working on making ABC build with CMake under yosys environment, noticed these couple of issues.
Very strange is that it builds currently on CI but it should really fail with missing io.h and some of defines.
There was also linking issue related to Abc_TtCanonicizeCA (due to namespace) so added that to .h as other calls and cleaned unneeded extern now.

@wjrforcyber

wjrforcyber commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

You are correct about this on io.h, it's better to solve all these warnings in future.

Reason about the "strange" and "should really fail" part:

So actually in the windows build log, the issue you proposed has already shown, currently they show as warning, check the latest windows log, there are:

 D:\a\abc\abc\src\base\main\mainUtils.c(103,11): warning C4013: 'isatty' undefined; assuming extern returning int [D:\a\abc\abc\abclib.vcxproj]
...
D:\a\abc\abc\src\sat\kissat\colors.c(16,35): warning C4013: '_isatty' undefined; assuming extern returning int [D:\a\abc\abc\abclib.vcxproj]
...
D:\a\abc\abc\src\sat\kissat\file.c(37,7): warning C4013: '_access' undefined; assuming extern returning int [D:\a\abc\abc\abclib.vcxproj]
...
D:\a\abc\abc\src\sat\kissat\file.c(60,20): warning C4013: 'S_ISDIR' undefined; assuming extern returning int [D:\a\abc\abc\abclib.vcxproj]
...

But I assume all of these could be found by UCRT , which the linker actually search (in the log, we have C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt). For _isatty and _access here they are handled.

PS: For S_ISDIR I'm not sure, it seems no code outside file.c calls any function defined in file.c.

@mmicko

mmicko commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Thank you @wjrforcyber for taking a look. Have set TreatSpecificWarningsAsErrors for this warning to make sure this does not appear in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants