Repository navigation
Conversation
Resolve direct ctx.read(Label(...)) inputs without materializing the referenced remote repository. RemoteExternalOverlayFileSystem already fetches the requested file. Keep ctx.path, execute inputs and label watching unchanged. In two matched cache restores, reading three files from a 50,000-file repository took 32.2–41.5s before and 7.4–7.7s after. Neither variant re-executed the producer; contents and recorded input markers matched. Add a regression for lazy reads, input changes, cache eviction retries and explicit ctx.path materialization.
github-actions
Bot
added
team-ExternalDeps
Member
|
Are the test failures related? |
Contributor
Author
|
Fabian is 1-upping me in #31493 |
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct
ctx.read(Label(...))calls currently materialize an entire remoterepository to read one file. Resolve direct reads without materialization
and use the remote filesystem's existing per-file reads.
ctx.pathandnative-process inputs still materialize the repository.
In two cache restores, reading three files from a 50,000-file repository
took 7.4–7.7s instead of 32.2–41.5s. Contents and recorded input markers
matched. Includes a regression for lazy reads, changed inputs, recovery after
cache eviction and explicit
ctx.pathbehavior.