[9.3.0] Fix builtin action resource set regression introdued by #29284 (https… - #31136
Merged
Merged
Conversation
(bazelbuild#30747) Fixes a regression introduced by bazelbuild#29284 where local resource specifications (`resources:*:*`, `cpu:*` and `memory:*`) affected builtin actions such as; - `test.xml` generator action - C spawn include scanner Also moves resource overriding into `ResourceSetOrBuilder` to reduce the risk of drift between `BaseSpawn` and `SimpleSpawn`. Deriving local resource sets in these builtin spawns causes otherwise lightweight tasks to backup (and temporarily block) other larger spawns due to them taking an unreasonably high number of resource permits. In the case of `test.xml` generation, when resources are exhausted it can cause tests to visibly appear as if they are running for much longer than they really are (exacerbation of an existing issue where `test.xml` generation scheduling is not differentiated from spawn running in UI and potentially elsewhere). No - [x] I have added tests for the new use cases (if any). - [x] I have updated the documentation (if applicable). RELNOTES: Fix for regression in bazelbuild#29284 that caused select builtin actions to incorrectly inherit resource set overrides. Closes bazelbuild#30747. PiperOrigin-RevId: 981231820 Change-Id: If2dd7b33fefca8ebe2ba4866cc87bc7316230fd1
github-actions
Bot
added
team-Performance
iancha1992
marked this pull request as draft
September 14, 2026 20:24
iancha1992
changed the title
Member
Author
|
Could you please review the changes in: Thank you! |
iancha1992
marked this pull request as ready for review
September 14, 2026 20:37
iancha1992
enabled auto-merge
September 14, 2026 20:37
Wyverald
approved these changes
Sep 14, 2026
Merged
via the queue into
bazelbuild:release-9.3.0
with commit Sep 15, 2026
4611dd7
43 checks passed
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…://github.com//pull/30747)
Fixes a regression introduced by #29284 where local resource specifications (
resources:*:*,cpu:*andmemory:*) affected builtin actions such as;test.xmlgenerator actionAlso moves resource overriding into
ResourceSetOrBuilderto reduce the risk of drift betweenBaseSpawnandSimpleSpawn.Deriving local resource sets in these builtin spawns causes otherwise lightweight tasks to backup (and temporarily block) other larger spawns due to them taking an unreasonably high number of resource permits. In the case of
test.xmlgeneration, when resources are exhausted it can cause tests to visibly appear as if they are running for much longer than they really are (exacerbation of an existing issue wheretest.xmlgeneration scheduling is not differentiated from spawn running in UI and potentially elsewhere).No
RELNOTES: Fix for regression in #29284 that caused select builtin actions to incorrectly inherit resource set overrides.
Closes #30747.
PiperOrigin-RevId: 981231820
Change-Id: If2dd7b33fefca8ebe2ba4866cc87bc7316230fd1
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Commit af88dde