Skip to content

chore: remove groodt from codeowners#3741

Merged
aignas merged 3 commits intobazel-contrib:mainfrom
rickeylev:rm.groodt
Apr 27, 2026
Merged

chore: remove groodt from codeowners#3741
aignas merged 3 commits intobazel-contrib:mainfrom
rickeylev:rm.groodt

Conversation

@rickeylev
Copy link
Copy Markdown
Collaborator

He's no longer active in the project

He's no longer active in the project
@rickeylev rickeylev requested a review from aignas as a code owner April 26, 2026 18:50
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/CODEOWNERS file by removing @groodt from the PyPI integration related paths. The review feedback points out that these specific entries are now redundant with global ownership rules and suggests removing them entirely to simplify the file.

Comment thread .github/CODEOWNERS
Comment on lines +10 to +11
/python/private/pypi/ @rickeylev @aignas
/tests/pypi/ @rickeylev @aignas
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the removal of @groodt, these specific ownership rules for /python/private/pypi/ and /tests/pypi/ have become redundant. The global ownership rule on line 3 already assigns @rickeylev and @aignas to all files in the repository. Removing these lines would simplify the CODEOWNERS file while maintaining the same ownership logic.

@aignas aignas merged commit 5d0016a into bazel-contrib:main Apr 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants