chore(pypi): remove unused config settings code#3739
chore(pypi): remove unused config settings code#3739aignas wants to merge 4 commits intobazel-contrib:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request streamlines the pip integration by removing the enable_pipstar feature, experimental_target_platforms attribute, and legacy configuration flags, while migrating entry point generation to py_console_script_binary. Review feedback highlights dead code regarding the extras parameter in wheel_installer.py and suggests a more robust method for Python version detection in pip_repository.bzl.
657d0db to
5f6fe90
Compare
These are unused? I thought the intent was to use them to allow dependency selection when requirement env markers can't do so. e.g., given requirements_musl.txt and requirements_glibc.txt, one would set |
Summary:
pip_*config settings since they have been no op for a while.Related #260.