chore: make pipstar non-switchable#3737
Merged
aignas merged 14 commits intobazel-contrib:mainfrom Apr 27, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the RULES_PYTHON_ENABLE_PIPSTAR and RULES_PYTHON_ENABLE_PYSTAR environment variables and their associated logic, effectively making the Starlark implementations the default. It also removes the legacy entry point generation mechanism in favor of py_console_script_binary. Feedback was provided regarding a potential breaking change in the whl_library_targets macro signature, where retaining the entry_points parameter is recommended for backward compatibility with vendored files. Additionally, a null check was suggested for the whl_metadata result in whl_library.bzl to prevent potential crashes if the metadata file is missing.
At the same time cleanup pystar env var docs. Also cleanup dead code.
aignas
force-pushed
the
aignas.chore.cleanup-legacy-pip-code
branch
from
116019e to
4f78a8c
Compare
rickeylev
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pipstar code has been there for some time and might be stable enough to not
have a fallback anymore.
Related #2949