Use rules_rs from_cargo for Jrsonnet - #282
Open
zbarsky-openai wants to merge 2 commits into
Open
Conversation
zbarsky-openai
marked this pull request as ready for review
July 22, 2026 17:50
Bump jsonnet and jsonnet_go to 0.22.0 so their C++ and Go rules load the external C++ providers required by Bazel 9. This also updates the transitive rules_go version from 0.53.0 to 0.59.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the Jrsonnet toolchain from
rules_rustand crate-universefrom_specstorules_rsandfrom_cargo. Add the minimal Cargopackage and lockfile, generate the existing Jrsonnet binary, use the
shared default Rust toolchain, cover Linux and macOS architectures, and
mark the Jsonnet extension and repository rule reproducible. This
removes the nightly host-tool downloads and avoids toolchain repository
name conflicts for consuming root modules.
Require
rules_rs0.0.95 because earlier releases generate an invalidlibrary target for the binary-only Jrsonnet crate and can mark ordinary
Linux hosts incompatible. The lockfile resolves Jrsonnet
0.5.0-pre97 from the existing
^0.5.0-pre95requirement.Update
jsonnetandjsonnet_goto 0.22.0 for Bazel 9. Their earlierversions use removed native C++ rules and select
rules_go0.53.0,whose
CcInforeference aborts analysis for every compiler. The updateselects the compatible
rules_go0.59.0 without adding a redundantdirect dependency.
Validated on Linux with Bazel 9.1.0 and 9.2.0: the root build and all
25 Go, 25 C++, and 25 Rust example tests pass with test caching disabled.
The original migration was also validated with Bazel 8.4.2. Locked Cargo
metadata and strict Bzlmod resolution pass. Bazel reports the existing
bazel_skylibminimum-version warning; it does not affect the build.