Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7bffff3004
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
alex-the-third
commented
Jul 24, 2026
fmeum
enabled auto-merge (squash)
July 24, 2026 16:48
fmeum
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure Windows runfiles lookup resolves the exact manifest key instead of a later suffix-matching entry.
Fixes #1271
Problem
BATCH_RLOCATION_FUNCTIONsearches the runfiles manifest with:findstr.exe /l /c:"!runfile_path! "Because the search is not anchored, looking up
repo/pkg/toolalso matches a line beginning withother/repo/pkg/tool.The loop processes every match, so a later suffix collision can overwrite the correct result. Generated Windows launchers may consequently execute or read the wrong runfile depending on manifest ordering.
Fix
Add
findstr's/boption so the literal search must begin at the start of the manifest line:findstr.exe /b /l /c:"!runfile_path! "The change is otherwise limited to a Windows-only regression test that places an exact entry before a suffix-colliding entry and verifies that the exact payload is executed.