Improve iframe dark mode sync and prevent duplicate listeners#1365
Open
yasnazariel wants to merge 1 commit intobase:masterfrom
Open
Improve iframe dark mode sync and prevent duplicate listeners#1365yasnazariel wants to merge 1 commit intobase:masterfrom
yasnazariel wants to merge 1 commit intobase:masterfrom
Conversation
…sync his update improves the dark mode synchronization logic for Chromatic iframes. Changes include: - Preventing duplicate event listeners using a dataset flag - Adding safety checks before calling postMessage on iframe contentWindow - Removing unnecessary polling via setInterval in favor of MutationObserver - Optimizing mutation handling loop for better performance - Using setAttribute for better DOM compatibilit
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the dark mode synchronization behavior for Chromatic iframes.
Changes
Impact
Notes
No functional UI changes — only internal improvements to iframe theme handling logic.