feat(enrich): IPv6 support for Cymru + ipinfo providers (#40) - #48
Merged
Merged
Conversation
…nfo v6 Cymru Lookup now branches on address family, querying origin6.asn.cymru.com with reversed nibbles for IPv6 while v4 keeps origin.asn.cymru.com. Adds reverseV6Nibbles helper and tests; confirms IPInfoProvider already emits the v6 literal in its request path. Closes #40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin6.asn.cymru.com(reversed nibbles); IPv4 unchanged onorigin.asn.cymru.com.reverseV6Nibbleshelper with a fixture-locked unit test.IPInfoProvideralready works for v6 (sends the v6 literal in the request path) via a httptest test — no production change needed.Test plan
go vet ./traceroute/enrich/...go test ./traceroute/enrich/...Closes #40