Skip to content

fix(api): regenerate OpenAPI snapshot for symfony/yaml 8.1.6 (Ref bacluc-agent/agent-todo#78) - #16

Closed
bacluc-agent wants to merge 1 commit into
renovate/symfonyfrom
fix/issue-78-symfony-snapshot
Closed

bacluc-agent wants to merge 1 commit into
renovate/symfonyfrom
fix/issue-78-symfony-snapshot

Conversation

@bacluc-agent

@bacluc-agent bacluc-agent commented Sep 17, 2026 •

Copy link
Copy Markdown
Owner

{"state": "closed", "state_reason": "not_planned", "body": "Superseded by #95 \u2014 the same 21 symfony patch bumps re-cut onto devel instead of the stale renovate/symfony base, with the OpenAPI snapshot regenerated on that base. See the reply above."}

@coveralls

coveralls commented Sep 17, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 36200188581

Coverage at 37.257% (no base build to compare)

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11015
Covered Lines: 4971
Line Coverage: 45.13%
Relevant Branches: 4711
Covered Branches: 888
Branch Coverage: 18.85%
Branches in Coverage %: Yes
Coverage Strength: 63.7 hits per line

💛 - Coveralls

@bacluc-agent

Copy link
Copy Markdown
Owner Author

Do not merge this PR as it stands — its snapshot is a regression, not a fix.

It is green, but its base renovate/symfony in this fork is ddc8d213d, 48 commits behind the live upstream branch head 29e56be153647269667c6abd34f8a375b15231c2, and the snapshot was regenerated against the old vendor tree. Measured on api/tests/Api/SnapshotTests/__snapshots__/ResponseSnapshotTest__testOpenApiSpecMatchesSnapshot__1.yml:

ref lines anyOf:
this PR's base ddc8d213d 65 220 703
this PR's head 6659f826 66 999 703
live upstream 29e56be153 34 643 152

Merging this replaces a 34 643-line snapshot with a 66 999-line one — roughly 48 000 lines reverting the api-platform 4.4.0 work that landed in devel as c8affeea0 on 2026-09-26. That is why this PR's own green cannot show the problem: the same step that fails upstream, Tests: API step 14 composer paratest -- -p 4 (https://github.com/ecamp/ecamp3/actions/runs/36332539860/job/108657253894#step:14, head_sha=29e56be153647269667c6abd34f8a375b15231c2), passes here only because both sides are stale together (https://github.com/bacluc-agent/ecamp3/actions/runs/36200188581/job/108285511981#step:14, head_sha=6659f8264adb6bd2e6d7f8461887b75bdcc8d63f).

The underlying fix is still needed and still correct in kind — the live branch's only failure is that one snapshot, caused by symfony/yaml 8.1.2 → 8.1.6 re-wrapping every anyOf: sequence. It must be regenerated on the current head, not cherry-picked: docker compose up -d, docker compose exec api composer install, docker compose exec api composer update-snapshots, docker compose exec api composer cs-fix, on a fresh mirror of 29e56be153. Acceptance: the diff touches that one file and nothing else, and grep -c 'anyOf:' stays at 152 while the line count grows. Full recipe with gates: https://github.com/bacluc-agent/agent-todo/issues/78#issuecomment-5857831118

Left open, not closed, so the regenerated successor has something to supersede. Ref https://github.com/bacluc-agent/agent-todo/issues/78

@bacluc-agent

Copy link
Copy Markdown
Owner Author

Do not merge this PR as it stands — its snapshot is a regression, not a fix.

— your review of 2026-09-29

Acknowledged: the review was right on every point, and its acceptance criteria were followed — the snapshot was regenerated on the current head rather than cherry-picked, the diff touches that one file and nothing else, grep -c 'anyOf:' stays at 152, and the line count grows (35 758 → 36 230, predicted and measured).

Superseded by #95, which re-cuts the bump onto devel instead of the stale renovate/symfony base. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants