Align parallel checkpoint with other SDKs: always emit SUCCEED#2426
Closed
GarrettBeatty wants to merge 2 commits into
Closed
Align parallel checkpoint with other SDKs: always emit SUCCEED#2426GarrettBeatty wants to merge 2 commits into
GarrettBeatty wants to merge 2 commits into
Conversation
The parent parallel context now always checkpoints as Action=SUCCEED with the summary (including CompletionReason) in the Payload field, matching the wire format used by the Python, JS, and Java SDKs. Previously the C# SDK emitted Action=FAIL for FailureToleranceExceeded, which left ContextDetails.Result empty (Payload is forbidden on FAIL updates) and diverged from the cross-SDK wire contract. The ParallelException is now thrown SDK-side after the checkpoint based on the CompletionReason in the reconstructed BatchResult.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Action=SUCCEEDwith the summary inPayload, matching the Python/JS/Java SDKs' wire format.Action=FAILforFailureToleranceExceeded, which leftContextDetails.Resultempty (the wire protocol forbidsPayloadon FAIL updates) and diverged from the cross-SDK contract.ParallelExceptionis now thrown SDK-side after the checkpoint, based onCompletionReasonin the reconstructedBatchResult.SUCCEEDEDparent with the summary inContextDetails.Result, matching real service behavior.Test plan
ParallelAsync_ReplayFailed_ThrowsParallelExceptionupdated and passing