Skip to content

chore(security): state where torch reaches the lock in its audit exceptions - #124

Merged
mahdi-shafiei merged 1 commit into
mainfrom
chore/torch-audit-reasons
Nov 18, 2026
Merged

mahdi-shafiei merged 1 commit into
mainfrom
chore/torch-audit-reasons

Conversation

@mahdi-shafiei

Copy link
Copy Markdown
Contributor

Summary

 [tool.substrax.audit-lock.ignore]
-"PYSEC-2025-194" = "torch, benchmark extra: no lockfile change closes it. ..."
+"PYSEC-2025-194" = "torch, in the data extra (torchcrepe, for the audio pitch operator),
+  benchmark and every all extra: ... datarax calls no torch.jit and loads torchcrepe's bundled
+  weights with weights_only=True. ..."

The same text for PYSEC-2026-139. Only the recorded reasons change; the ignores stay.

Evidence

  • uv.lock: torch 2.10.0 is required by datarax[all], [all-cpu], [all-macos],
    [benchmark] and [data], and by litdata, mosaicml-streaming, torchaudio, torchcrepe and
    torchvision. The old reason named only benchmark.
  • CUDA: the cp312 manylinux x86_64 wheels of torch 2.11.0, 2.12.0, 2.13.0, 2.14.0, 2.14.1 and
    2.15.0 require cuda-toolkit 13 and nvidia-cudnn-cu13 (wheel metadata on PyPI); 2.10.0
    requires nvidia-cuda-runtime-cu12. PYSEC-2025-194 is fixed only from 2.13.0.
  • Reach: GHSA-rrmf-rvhw-rf47 (CVE-2025-3000) is memory corruption through torch.jit.script.
    Neither datarax's src nor torchcrepe calls torch.jit. datarax's one torch call is
    torch.load(..., weights_only=True) of torchcrepe's bundled weights (crepe_model.py:301).
  • The audit (substrax audit_lock.py at f05e0e5, pip-audit 2.10.1) passes over all 15 extras;
    contract and hygiene tests: 87 passed; pre-commit passed.

Merge Danger

Door: two-way

Blast Radius: none

Text of two ignore reasons and a CHANGELOG entry; the audited set is unchanged.

…ptions

The reasons for PYSEC-2025-194 and PYSEC-2026-139 named only the
benchmark extra; torch also comes in through the data extra, by
torchcrepe for the audio pitch operator, and through every all extra.
They stay open: the Linux wheels of each minor release from 2.11.0 to
2.15.0 require CUDA 13, and PYSEC-2026-139 has no fixed release. datarax
calls no torch.jit and loads torchcrepe's weights with weights_only=True.
@mahdi-shafiei
mahdi-shafiei marked this pull request as ready for review November 18, 2026 22:59
@mahdi-shafiei
mahdi-shafiei merged commit 10fee08 into main Nov 18, 2026
30 checks passed
@mahdi-shafiei
mahdi-shafiei deleted the chore/torch-audit-reasons branch November 18, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant