Repository navigation
fix: preserve add-item drafts after local acceptance failures - #290
Draft
brianorwhatever wants to merge 1 commit into
Draft
brianorwhatever wants to merge 1 commit into
brianorwhatever wants to merge 1 commit into
Conversation
|
🚅 Deployed to the boop-pr-290 environment in Friends
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If adding item A fails before it enters the local queue, AddItemInput restored A into the input even when the user had already typed B. This overwrote the newer draft.
Change
This is ephemeral recovery for failures before local queue acceptance, not another server-sync queue. Once onAddItem accepts an item, existing OfflineRecovery owns server retries. Drafts/retry entries are not promised to survive reload or leaving the list/account.
Verification
Limits
Full repository tests, TypeScript/lint/build, browser E2E, native builds and real IndexedDB integration have not been run locally. Focused tests isolate the local acceptance promise and do not validate the entire offline UX. Automatic CI will be checked on the exact PR head.
Draft only; no merge or deployment.