Skip to content

Angrimson bug fix collection - #1325

Open
angrinord wants to merge 7 commits into
mainfrom
angrimson-bug-fix-collection
Open

Angrimson bug fix collection#1325
angrinord wants to merge 7 commits into
mainfrom
angrimson-bug-fix-collection

Conversation

@angrinord

Copy link
Copy Markdown

2 bug fixes cherry-picked from dev branch.

Reference Issues/PRs

Fixes #1306 and #1314

Problem Description and Changes

Two bugs collected from dev.

  • scikit-learn 1.9 deprecated an alias for np.float32 called DTYPE. Change removes references to deprecated alias.
  • forbidden clauses weren't being preserved. Change fixes that and adds a test.

Type Of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is Missing?

n/a

Checklist

Go over all the following points, and put an x in all the boxes that apply.
Should there be a good argument to differ, please provide a reasoned explanation.

  • My change is based on the latest stage of the develop branch.
  • My change required a change of the documentation, which has been done.
  • I checked that the documentation can be build, visualizes everything as expected, and does not contain any warnings.
  • I have added/adapted tests to cover my changes.
  • The tests can be executed successfully.
  • I have added a description of the changes to CHANGELOG.rst.

Any other comments?

I suggest updating version number to v2.4.1

@angrinord
angrinord requested review from kalifou and mwever July 23, 2026 14:36
daphne12345 and others added 2 commits July 23, 2026 16:41
(cherry picked from commit 2bd3f5f)
@angrinord

Copy link
Copy Markdown
Author

This should also stop main from failing its scheduled tests.

Comment thread smac/utils/configspace.py
@kalifou

kalifou commented Aug 12, 2026

Copy link
Copy Markdown

Hi!
The PR generally looks good to me. As mentioned above, since the adds are technical and specific, I thought a couple of lines of comments could help clarify the fix.
Thanks

@mwever mwever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@mwever mwever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some logs to the CHANGELOG.md for this bugfix?

angrinord and others added 3 commits August 20, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Some generated configs don't satisfy forbiddens

5 participants