fix: opt in clang-cl for ARM ggml - #20
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit, OFF-by-default CMake opt-in intended to support Windows ARM64 builds where clang-cl is detected as MSVC by ggml’s ARM guard, by patching the fetched ggml v0.9.5 source before add_subdirectory() is invoked.
Changes:
- Introduces
CORTEXT_ALLOW_CLANGCL_ARMCMake option (default OFF) to gate any behavior change. - Adds
cortext_patch_fetched_ggml_arm_guard()to apply a narrowly-scoped, exact/idempotent patch to ggml’s ARM compiler guard. - Wires the patch into the ggml FetchContent path immediately before adding ggml as a subdirectory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+414
to
+417
| set(_cortext_ggml_arm_guard_old | ||
| [=[if (MSVC AND NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")]=]) | ||
| set(_cortext_ggml_arm_guard_new | ||
| [=[if (MSVC AND NOT CMAKE_C_COMPILER_ID STREQUAL "Clang" AND NOT CORTEXT_ALLOW_CLANGCL_ARM)]=]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows ARM64 with clang-cl reports MSVC compatibility to ggml's ARM guard. Add an explicit OFF-by-default
CORTEXT_ALLOW_CLANGCL_ARMoption and a narrowly scoped exact/idempotent patch to fetched ggml v0.9.5 before add_subdirectory when opted in. Missing or ambiguous guard text fails configure; default behavior remains unchanged.