fix: complete ARM NEON sqlite-vec portability - #18
Merged
Conversation
gabewillen
force-pushed
the
fix/arm-native-cmake
branch
from
August 7, 2026 07:31
ad3b775 to
c9a0a93
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the ARM NEON implementation in the vendored sqlite-vec extension to complete a portability fix related to signed/unsigned vector-lane handling during widening and accumulation for the int8 L1 distance path.
Changes:
- Introduces a small NEON helper (
l1_int8_neon_pairwise_abs) to centralize the “reinterpret as unsigned while widening” logic. - Replaces repeated inline widening/accumulation expressions with the helper to avoid signed/unsigned mismatches under stricter compilers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the ARM NEON sqlite-vec fix after strict GCC cross syntax found a second signed/unsigned mismatch.
The helper now reinterprets signed byte differences before unsigned widening and reinterprets the final unsigned lanes for signed accumulation. Apple Clang and GCC ARM syntax checks pass.