fix: compile sqlite-vec NEON on ARM - #17
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes ARM NEON compilation for the vendored sqlite-vec distance kernel by ensuring the vabdq_s8 absolute-difference results are treated as unsigned bytes before being widened and accumulated. This aligns the types expected by vpaddlq_u8 / vpaddlq_u16 and preserves correct 0..255 absolute-difference semantics.
Changes:
- Reinterpret
int8x16_tabsolute-difference vectors asuint8x16_tbeforevpaddlq_u8widening inl1_int8_neon. - Add an in-code comment explaining why the reinterpret is required for correct accumulation of 128..255 differences.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ARM NEON compilation in the tracked sqlite-vec source.
vabdq_s8produces signed vectors, whilevpaddlq_u8requires unsigned vectors. Reinterpret the absolute-difference bytes before widening, preserving the intended 128..255 byte values and allowing GCC/Clang ARM builds.