fix: allow clang-cl for ARM ggml builds - #16
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the build configuration to allow Windows ARM64 builds (including Node prebuilds) to use the clang-cl toolchain needed by ggml while keeping the existing safety guard that prevents unsupported MSVC-only configurations for embedded AIST model blobs.
Changes:
- Narrowed the
CORTEXT_EMBED_AIST_MODEL+MSVCfatal guard to trigger only for non-Clang MSVC-compatible compilers. - Preserves the existing error message and guidance while permitting
clang-cl(compiler IDClang) to proceed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows Windows ARM64 Node prebuilds to use the clang-cl toolchain required by ggml.
The existing ARM guard rejected all
MSVC-compatible compilers; clang-cl reports MSVC compatibility while its compiler ID is Clang. This narrows the rejection to non-Clang MSVC and preserves the safety check.