fix(ci): drop goreleaser --release-notes flag#104
Merged
Conversation
The Release workflow failed with `open ./RELEASE_NOTES.md: no such file or directory` because the fork has no RELEASE_NOTES.md. Drop the flag so goreleaser auto-generates the release notes from its changelog config instead of requiring a hand-written file.
giunatale
approved these changes
Jun 22, 2026
julienrbrt
approved these changes
Jun 22, 2026
release.github was hard-coded to the upstream cosmos/cosmos-sdk repo, so goreleaser would 403 trying to publish the release with this fork's token. Point it at atomone-hub/atomone-sdk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Release workflow (triggered by the
v0.500.0tag) failed:release.ymlruns goreleaser with--release-notes ./RELEASE_NOTES.md, but this fork has noRELEASE_NOTES.mdand it isn't part of its release flow. The workflow only fires on finalvX.Y.Ztags (not-rc.*), so the gap stayed hidden through the rc's.Fixes
--release-notes— goreleaser then auto-generates the notes from itschangelogconfig (changelog.disable: false) instead of requiring a hand-written file..goreleaser.ymlhard-codedrelease.github.owner: cosmos / name: cosmos-sdk(upstream), so goreleaser would 403 publishing with this fork's token. Nowatomone-hub / atomone-sdk.Follow-up (not in this PR)
The existing
v0.500.0tag points to a commit with the old workflow; tag-triggered runs use the workflow at the tagged commit, so after merge the tag must be re-pointed to the merged commit for these fixes to take effect.Part of #90.