Repository navigation
Parity script: find runs nested by session and other entities - #195
Merged
Merged
Conversation
…rkflow folders `qsmxt run` keeps a run's record, methods text and graph in a workflow folder nested by the run's entities (workflow/sub-1/ses-2/acq-x_run-1/), not workflow/<run name>/. The script now finds the folder that holds <run>_runrecord.json, and picks the published images by their run name rather than by a top-level folder named after it. A new case, tkd-session, names the phantom's files sub-phantom_ses-1_acq-bridge_run-1 (tests/e2e/phantom.js takes the entities), so the parity run covers a session level. Fixes #193 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #193
What changes
scripts/parity/e2e.mjslooked for the native run's pipeline graph, methods text and run record atworkflow/<run>/<run>_*.qsmxt runnests that folder by the run's entities (workflow/sub-1/ses-2/acq-x_run-1/), so on data with a session the checks said the files were not written.<run>_runrecord.json, and reads the planned graph, the graph the run took, the methods text and the record from there.workflow/), not by a top-level folder named after the run, which also failed with a session (sub-1/ses-2/anat/…).tkd-session: the phantom's files are namedsub-phantom_ses-1_acq-bridge_run-1_…and placed insub-phantom/ses-1/anat/.tests/e2e/phantom.jstakes anentitiesoption for this (defaultsub-phantom, so the browser tests are unchanged).Decisions taken
qsmxtbinary (Derivatives::workflow_run_dir), not in the engine qsmbly links, so the script finds the folder by the record's file name rather than copying the naming rule.Not done here
The export bundle writes the graph the run took at
workflow/<run>/, which matchesqsmxt runonly for runs without a session or other entities. Fixing that needs the folder naming in the engine. A QSMxT issue draft is written (not filed). The new case runs as planned, so it has no such graph and is not affected.🤖 Generated with Claude Code