Migrate cgmath dependency to cgmath-next (maintained successor, soundness fix) - #574
Open
kent-tokyo wants to merge 1 commit into
Open
Migrate cgmath dependency to cgmath-next (maintained successor, soundness fix)#574kent-tokyo wants to merge 1 commit into
kent-tokyo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the
cgmathdependency tocgmath-next, a maintained, source-compatible successor.cgmathcurrently has two open RustSec advisories: RUSTSEC-2026-0196 (unmaintained) and RUSTSEC-2026-0197 (a soundness issue inswap_columns).cgmath-nextfixes the soundness issue and continues receiving maintenance.What changed
That's it -- no source changes.
cgmath-next's compiled library name is stillcgmath, so everyuse cgmath::...in this crate keeps working unchanged.Verification
cgmath0.18.0 (docs/api-inventory.mdincgmath-next).cargo check --no-default-featurespasses clean.cargo test --no-default-features --libpasses (0 tests -- this crate has none insrc/, confirmed unchanged from baseline).three-dis one of 5 real reverse-dependency cratescgmath-nextverifies against directly in its own CI/fixtures (compat/fixtures/reverse-deps/RESULTS.md).One honest note:
three-d-asset(this crate's own dependency) still depends on realcgmathinternally, so bothcgmathandcgmath-nextend up in the build graph. This didn't cause any conflict forthree-ditself (no shared scope between the two), but full leverage would eventually wantthree-d-assetmigrated too -- happy to send that PR as well if useful.Please don't hesitate to close this if it doesn't fit the project's direction -- happy to discuss any concerns.