Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the
php-prebuiltshortname for a second, complementary PHP plugin: prebuilt, relocatable PHP binaries for frozen EOL versions (5.4.45 through 8.1.34) on linux-x86_64.This does not change
plugins/php.asdf-community/asdf-phpis actively maintained and stays the default; it compiles PHP from source via php-build. The new plugin solves a different problem: legacy PHP that no longer compiles on a current distro because of OpenSSL / bison / libxml2 / ICU drift. It installs a checksum-verified, self-contained artifact instead. Users opt in explicitly:asdf plugin add php-prebuilt asdf install php-prebuilt 7.4.33 asdf local php-prebuilt 7.4.33The plugin name is the tool name in asdf, so
.tool-versionsmust usephp-prebuilt. Both migration paths have been verified against asdf 0.20.2 and documented in the plugin README.Scope is deliberately narrow: no macOS and no arm64 artifacts have been built, and no PHP 8.2+ versions are offered. The plugin README states those limits up front.
Checklist
scripts/format.bash— the README row is aligned to the existing table and passes Prettier on an LF-normalized copy. No shell scripts were added, so shfmt is not applicable.scripts/test_plugin.bash --file plugins/php-prebuilt—OK plugins/php-prebuilt.42501403364: the contract suite (65 checks) plus a realasdf-vm/actions/plugin-test@v4job that clones the plugin, adds it, installs 7.4.33 from a published artifact and runsphp -v. The plugin implements all three required callbacks (list-all,download,install).