chore: raise MSRV and toolchain to 1.85#223
Merged
Merged
Conversation
1.85 stabilized the 2024 edition, which a growing share of the ecosystem now requires in their manifests: url >= 2.5.1 pulls idna_adapter and rmp-serde 1.x ships an edition2024 manifest, both of which Cargo 1.78 cannot even parse. Staying on 1.78 was blocking those dependency updates (#121, #222) while the lockfile aged. Raise rust-version to 1.85 and pin rust-toolchain to 1.85.0, keeping the dev/CI toolchain and the MSRV coupled as before. The msrv job picks the new floor up from Cargo.toml automatically. Verified locally with cargo 1.85.0: cargo check --workspace --all-targets --locked Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raise the MSRV and the pinned dev/CI toolchain from 1.78 to 1.85, keeping them coupled:
Cargo.tomlrust-versionrust-toolchainchannelThe
msrvjob readsrust-versionfromCargo.tomland the other jobs readrust-toolchain, so CI follows automatically.Why
1.85 stabilized the 2024 edition (released 2025-02-20), and parts of the ecosystem now ship manifests that require it — Cargo 1.78 cannot even parse them:
url >= 2.5.1→idna 1.x→idna_adapter(edition2024) — blocks chore(deps): update rust crate url to v2.5.8 #121rmp-serde 1.x(edition2024 manifest) — blocks chore(deps): update rust crate rmp-serde to v1.3.1 #222Staying on 1.78 meant those dependency updates fail CI structurally (
feature edition2024 is required), and the lockfile ages while Renovate keeps retrying. 1.85 is ~16 months old at this point, which is still a conservative floor.Verification
cargo check --workspace --all-targets --lockedpasses locally undercargo 1.85.0(same invocation as themsrvjob).Follow-ups (separate PRs)
Cargo.tomlreferences constraints from the 1.78 era and can be revisited.🤖 Generated with Claude Code