Update bitWrite.adoc

[HowardWParr]

The bitWrite() function does return the updated value.

[per1234]

Suggested change

Serial.println(bitWrite(x, 1, 1), BIN); // 10000011

The example is meant to be a demonstration of the basic usage of the function. Even though it is indisputable that the "return" of the macro must be documented correctly, I don't think it needs to be demonstrated since this is not a common use pattern for bitWrite.

[HowardWParr]

If "it is indisputable that the "return" of the macro must be documented correctly" then document it correctly. I bring this to your attention as there are similar functions with this usage documented. Consistency is a hallmark of good documentation. Howard

[per1234]

Clearly we are in agreement on this subject, so there is no need to discuss it further. Let's focus on the specifics of my review so we can make progress in that direction.

[HowardWParr]

The specifics of your review were not very clear. However, if the "Returns" section of the documentation is updated from "Nothing" to indicate that there is in fact a return from this function, then that's all I'm looking for..

[per1234]

@HowardWParr if you agree with the change I requested during my review, then make that change.

If you disagree with the change I requested, then provide a clear explanation of why you disagree.

I notice that you are replying via email. Please come here to the pull request page on GitHub so that you can be sure to see the actual suggestion I made. The pull request is at this URL:

#885

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}