fix: replace assert with ValueError for state validation#1219
Merged
KazuCocoa merged 1 commit intoappium:masterfrom Apr 19, 2026
Merged
Conversation
The use of `assert` for application logic or state checking is discouraged because assertions are removed when Python runs with optimization (-O). This change replaces `assert self.caps` with an explicit `if` check that raises `ValueError`, ensuring that the driver capabilities are always validated even in optimized environments.
KazuCocoa
approved these changes
Apr 19, 2026
Dor-bl
deleted the
fix-security-assert-vulnerability-13839261523439253099
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of
assertfor application logic or state checking is discouraged because assertions are removed when Python runs with optimization (-O). This change replacesassert self.capswith an explicitifcheck that raisesValueError, ensuring that the driver capabilities are always validated even in optimized environments.