test: raise timeout for presigned URL fetches in integration tests#757
Open
test: raise timeout for presigned URL fetches in integration tests#757
Conversation
The 5s HTTP timeout was too tight for presigned-URL fetches against the Apify platform and occasionally tripped, causing flaky failures. Bump to 30s to absorb transient slowness while still failing fast on real issues. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #757 +/- ##
==========================================
- Coverage 95.89% 95.67% -0.22%
==========================================
Files 45 45
Lines 5115 5115
==========================================
- Hits 4905 4894 -11
- Misses 210 221 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 5s HTTP timeout on presigned-URL fetches in integration tests was too tight for the external Apify platform and occasionally tripped, causing flaky failures (e.g. this job run). Bumped the timeout to 30s in all four affected tests (
test_dataset.py,test_key_value_store.py) to absorb transient slowness while still failing fast on a truly broken endpoint.🤖 Generated with Claude Code