Repository navigation
Port build-versions.py to Python 3 and read its modules from the poms - #1709
Merged
Merged
Conversation
release.sh builds release.properties for release:prepare from the output of build-versions.py, which gives every module its release version and the next development version. The script was Python 2 behind #!/usr/bin/python, so where python is Python 3 release.sh stopped there with a SyntaxError. Its module list was also incomplete. It read the <modules> of the root pom and of wicket-native-websocket only, derived artifact IDs from directory names and always added wicket-experimental under the org.apache.wicket.experimental.wicket8 groupId. The modules under wicket-experimental were missing (wicket-metrics, and on 9.x and 8.x wicket-http2 and its submodules), and wicket-experimental itself was listed twice, under two wrong groupIds. The release plugin then fell back to prompting or its own default for those modules. The script now runs on Python 3 and walks the <modules> tree from the root pom, taking the groupId and artifactId each pom declares. Its output matches the reactor: 34 modules on master. Adding or removing a module no longer needs a change to the script. GitHub issue #1708 Generated-by: Claude Code (Claude Opus 5.5)
This was referenced Oct 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1709 +/- ##
=========================================
Coverage 62.32% 62.32%
- Complexity 11360 11363 +3
=========================================
Files 1253 1253
Lines 48438 48438
Branches 6794 6794
=========================================
+ Hits 30188 30191 +3
+ Misses 15551 15550 -1
+ Partials 2699 2697 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1708, backported in #1710 (10.x), #1711 (9.x) and #1712 (8.x).
build-versions.pywrites the per-module versions thatrelease.shappends torelease.propertiesforrelease:prepare. It now runs on Python 3 and takes its module list from the poms.The old script failed on every line that still releases. It was Python 2 behind
#!/usr/bin/python, so wherepythonis Python 3release.shstopped with aSyntaxError. Its module list came from the<modules>of the root pom andwicket-native-websocketonly, with artifact IDs derived from directory names, so the modules underwicket-experimentalwere missing andwicket-experimentalwas listed twice under two wrong groupIds. The issue has the per-branch table.The script now walks the
<modules>tree from the root pom and emits each module with the groupId and artifactId its pom declares, inheriting the groupId from<parent>where the pom has none. Adding or removing a module needs no change to the script.Review
The only file is
build-versions.py, one commit. The output format is unchanged, sorelease.shneeds no change.Risk
Only release tooling changes; nothing in the build or the artifacts does. A module declared only inside a profile would also be emitted, since the script does not evaluate profiles; no branch has one.
Tests
./build-versions.py 11.0.0 11.1.0-SNAPSHOTemits 34 modules, the same 34 as Maven's reactor build order (mvn -o validate), withorg.apache.wicket.experimental.wicket10forwicket-experimentalandwicket-metrics.wicket-10.xandwicket-9.xand 33 onwicket-8.x, each matching that branch's<modules>tree. Maven itself was not run on those branches.🤖 Generated with Claude Code