Skip to content

Include GitHub issues in the release notes built by build-changelog.sh (9.x) - #1703

Merged
dashorst merged 1 commit into
wicket-9.xfrom
changelog-github-issues-9.x
Oct 23, 2026
Merged

dashorst merged 1 commit into
wicket-9.xfrom
changelog-github-issues-9.x

Conversation

@dashorst

@dashorst dashorst commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Backport of #1701 to wicket-9.x, part of #1699. The backport is one commit, squashed from the five on master (153eda1..ad352df); the script is identical to master's. 9.25.0 combines WICKET-7205, which has 9.25.0 as fix version, WICKET-7199, which is still open in Jira and comes from the commit subjects, and GitHub issues.

Regenerating a release's notes needs the rel/wicket-* tags fetched: the previous tag sets the commit range.

Output on wicket-9.x (9.25.0)

Run at this branch's tip with --force and Enter at the prompt. Without --force the run ends after the list of open issues and leaves the changelog unchanged. GH-1699 is listed, and flagged as open, because this branch's own commit references it.


Apache Wicket release notes generator
=====================================
This tool collects the issues resolved in the upcoming release from JIRA
and GitHub, and merges them with the existing CHANGELOG in a text format.

Version to collect the release notes for: 9.25.0
Commits searched for GitHub issues:       rel/wicket-9.24.0..HEAD

Press <enter> to continue 

Collecting the resolved issues -- making web requests
  - retrieving JIRA issues fixed in 9.25.0: 1
  - retrieving JIRA issues referenced since rel/wicket-9.24.0: 2
  - retrieving GitHub issues referenced since rel/wicket-9.24.0: 2
  - looking up GitHub copies of the JIRA issues: 0

These GitHub issues are fixed in this release, but still open. Close them once every
branch that needs the fix has it:

    GH-1699	Include GitHub issues in the release notes built by build-changelog.sh

Merging the release notes anyway because of --force.

  - merging release notes into changelog: done

diff --git a/CHANGELOG-9.x b/CHANGELOG-9.x
index 3a70b6b6be..9449dce560 100644
--- a/CHANGELOG-9.x
+++ b/CHANGELOG-9.x
@@ -2,6 +2,20 @@ This file contains all changes done in releases for Apache Wicket 9.x.
 
 =======================================================================
 
+Release Notes - Wicket - Version 9.25.0
+
+** Bug
+
+    * [WICKET-7199] - Vulnerable dependencies need to be updated
+    * [WICKET-7205] - CSP-Headers not set if RenderPageRequestHandler wrapped in more than one IRequestHandlerDelegates
+    * [GH-1576] - BUG since 10.11.0: Wrong escaping in Button label,while getEscapeModelStrings=false
+
+** Task
+
+    * [GH-1699] - Include GitHub issues in the release notes built by build-changelog.sh
+
+=======================================================================
+
 Release Notes - Wicket - Version 9.24.0
 
 ** Task

[detached HEAD f642fa113c] Added CHANGELOG for release 9.25.0
 1 file changed, 14 insertions(+)

The CHANGELOG-9.x file has been updated and committed.

To revert the changes to the CHANGELOG:

    git reset HEAD^ --hard

Have fun!

🤖 Generated with Claude Code

build-changelog.sh built the release notes only from Apache Jira: it
looked up the version id on Jira's ReleaseNote.jspa page and copied that
page's text notes into the changelog. Issues are filed on GitHub now, so
their fixes never reached the changelog. The page also answers anonymous
requests with 401 by now, so the script failed for every version, and
Jira is read-only, so a Jira issue fixed since can no longer be resolved
or given a fix version.

The script now builds the notes of a release from the commits since the
previous release:

- Jira issues: the ones resolved as Fixed with the release as fix
  version, through the anonymous REST API, plus the ones whose key is in
  the subject of a commit in the range and of no commit before it. An
  issue resolved otherwise than as Fixed is left out.
- GitHub issues: the ones referenced in a commit subject, or in the
  body as "GitHub issue #N" or after fixes, closes or resolves. A pull
  request contributes the issues it closes. Issues closed as not
  planned or as duplicates are left out.
- A GitHub issue whose title starts with a Jira key, as in
  "[WICKET-1234] Summary", is a copy of that Jira issue and is listed
  under the Jira key only.

The previous release is the rel/wicket-* tag with the highest version
below the one being built; --since overrides it. GitHub issues get the
[GH-N] key and are grouped by their issue type: Bug, Feature (as New
Feature) and Task. The layout of the notes is unchanged, so release.sh
still reads them.

Before it touches the changelog, the script stops with an error when a
GitHub issue in the notes is still open, a GitHub copy of a Jira issue
in the notes is open, or a GitHub issue has no type. Closing an issue
is left to a person, once every branch that needs the fix has it;
--force merges the notes anyway.

The script now runs under bash and needs jq and a logged-in GitHub CLI.
A version given as argument is used as is, and a changelog that does not
exist yet is created.

Backport of 153eda1..ad352df from master.

GitHub issue #1699

Generated-by: Claude Code (Claude Opus 5.5)
@dashorst
dashorst force-pushed the changelog-github-issues-9.x branch from 4a5ba98 to fe5553a Compare October 23, 2026 12:11
@dashorst
dashorst merged commit abdff19 into wicket-9.x Oct 23, 2026
0 of 2 checks passed
@dashorst
dashorst deleted the changelog-github-issues-9.x branch October 23, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant