SINGA-152 Worker class needs to take greater responsibility of its setting up#137
Open
undisputed-seraphim wants to merge 23 commits intoapache:masterfrom
undisputed-seraphim:experimental
Open
SINGA-152 Worker class needs to take greater responsibility of its setting up#137undisputed-seraphim wants to merge 23 commits intoapache:masterfrom undisputed-seraphim:experimental
undisputed-seraphim wants to merge 23 commits intoapache:masterfrom
undisputed-seraphim:experimental
Conversation
Contributor
undisputed-seraphim
commented
Mar 20, 2016
undisputed-seraphim
commented
- Move setup code from Driver::CreateWorkers to Worker::Setup and debug any issues that may arise.
Merge with upstream.
…be sure that the did passed into SetupDevice is always correct.
… always be sure that the did passed into SetupDevice is always correct." This reverts commit c84c087.
…-singa into reorganize
| << " start on " << (device >= 0 ? "GPU " + std::to_string(device) : "CPU"); | ||
| if (device >= 0) | ||
| context->ActivateDevice(device); | ||
| << " start on " << (device_type_ >= 0 ? "GPU " + std::to_string(device_type_) : "CPU"); |
Member
There was a problem hiding this comment.
need to activate the device if it is a GPU?
Member
|
pls checkout those conf files that are not relevant to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.