Skip to content

MINOR: Fix Spotless formatting in TestCompressionCodec#3551

Merged
wgtmac merged 1 commit intoapache:masterfrom
RussellSpitzer:SpotlessFix
May 8, 2026
Merged

MINOR: Fix Spotless formatting in TestCompressionCodec#3551
wgtmac merged 1 commit intoapache:masterfrom
RussellSpitzer:SpotlessFix

Conversation

@RussellSpitzer
Copy link
Copy Markdown
Member

Summary

Master CI (Hadoop 3) has been red since #3486 landed because parquet-hadoop's spotless:check is flagging TestCompressionCodec.testLz4RawHeapDecompressorCanCopyLargePage:

[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.46.1:check (default) on project parquet-hadoop: The following files had format violations:
[ERROR]     src/test/java/org/apache/parquet/hadoop/codec/TestCompressionCodec.java
[ERROR]         @@ -195,8 +195,7 @@
...
[ERROR]         -    try (TrackingByteBufferAllocator allocator =
[ERROR]         -            TrackingByteBufferAllocator.wrap(new DirectByteBufferAllocator());
[ERROR]         +    try (TrackingByteBufferAllocator allocator = TrackingByteBufferAllocator.wrap(new DirectByteBufferAllocator());

This PR is just the output of mvn spotless:apply for that one line so the build can go green again.

Test plan

  • ./mvnw spotless:check passes locally across all modules with JDK 17

Consolidate the try-with-resources allocator declaration in
testLz4RawHeapDecompressorCanCopyLargePage onto a single line so the
file passes spotless:check. Master CI has been failing on this since
apacheGH-3478 (apache#3486).
Copy link
Copy Markdown
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was wondering why this popped up all of a sudden 👍

@RussellSpitzer
Copy link
Copy Markdown
Member Author

Yeah I thought someone else would clear this up, but I was getting sad that my automation pr wasn't green so I fixed it. I should probably be helping out here more anyway

@wgtmac wgtmac merged commit d70b8ed into apache:master May 8, 2026
5 checks passed
@wgtmac
Copy link
Copy Markdown
Member

wgtmac commented May 8, 2026

Thanks @RussellSpitzer for fixing this and @Fokko for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants