Skip to content

HDDS-17835. S3 DeleteObjects deletes the object when Content-MD5 is wrong - #12094

Draft
Gargi-jais11 wants to merge 1 commit into
apache:masterfrom
Gargi-jais11:HDDS-17835
Draft

Gargi-jais11 wants to merge 1 commit into
apache:masterfrom
Gargi-jais11:HDDS-17835

Conversation

@Gargi-jais11

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

POST /?delete accepts a Content-MD5 that does not match the delete XML and still deletes the key.

AWS requires Content-MD5 on DeleteObjects. A mismatch must be HTTP 400 BadDigest, and the object must stay. Ozone returns HTTP 200, lists the key under Deleted, and the next HeadObject is 404.

Content-MD5 is already checked on PutObject and UploadPart. A wrong value there is BadDigest and the object is not stored. BucketEndpoint.multiDelete never reads the header.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-17835

How was this patch tested?

Added unit tests and integration test. As well as verified this manually.

@github-actions github-actions Bot added the s3 S3 Gateway label Nov 19, 2026

@sreejasahithi sreejasahithi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Gargi-jais11 for the PR

Comment on lines +47 to +61
@Override
public MultiDeleteRequest readFrom(Class<MultiDeleteRequest> clazz, Type type, Annotation[] annotations,
MediaType mediaType, MultivaluedMap<String, String> httpHeaders, InputStream inputStream)
throws WebApplicationException {
final byte[] body;
try {
body = IOUtils.toByteArray(inputStream);
} catch (IOException ex) {
throw new WebApplicationException(ex);
}
MultiDeleteRequest request = super.readFrom(clazz, type, annotations, mediaType, httpHeaders,
new ByteArrayInputStream(body));
request.setBodyContentMD5(DigestUtils.md5Hex(body));
return request;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the new MultiDeleteRequestUnmarshaller.readFrom override, the body read failure is wrapped in a plain WebApplicationException.
This maps to a 500 with no S3 XML error body. Previously this class inherited MessageUnmarshaller.readFrom, where any failure is routed through wrapOS3Exception(newError(INVALID_REQUEST, e)) -> 400 + a well-formed S3 error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s3 S3 Gateway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants