Repository navigation
HDDS-17835. S3 DeleteObjects deletes the object when Content-MD5 is wrong - #12094
Draft
Gargi-jais11 wants to merge 1 commit into
Draft
Gargi-jais11 wants to merge 1 commit into
Gargi-jais11 wants to merge 1 commit into
Conversation
sreejasahithi
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Gargi-jais11 for the PR
Comment on lines
+47
to
+61
| @Override | ||
| public MultiDeleteRequest readFrom(Class<MultiDeleteRequest> clazz, Type type, Annotation[] annotations, | ||
| MediaType mediaType, MultivaluedMap<String, String> httpHeaders, InputStream inputStream) | ||
| throws WebApplicationException { | ||
| final byte[] body; | ||
| try { | ||
| body = IOUtils.toByteArray(inputStream); | ||
| } catch (IOException ex) { | ||
| throw new WebApplicationException(ex); | ||
| } | ||
| MultiDeleteRequest request = super.readFrom(clazz, type, annotations, mediaType, httpHeaders, | ||
| new ByteArrayInputStream(body)); | ||
| request.setBodyContentMD5(DigestUtils.md5Hex(body)); | ||
| return request; | ||
| } |
Contributor
There was a problem hiding this comment.
In the new MultiDeleteRequestUnmarshaller.readFrom override, the body read failure is wrapped in a plain WebApplicationException.
This maps to a 500 with no S3 XML error body. Previously this class inherited MessageUnmarshaller.readFrom, where any failure is routed through wrapOS3Exception(newError(INVALID_REQUEST, e)) -> 400 + a well-formed S3 error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
POST /?deleteaccepts a Content-MD5 that does not match the delete XML and still deletes the key.AWS requires
Content-MD5on DeleteObjects. A mismatch must be HTTP 400 BadDigest, and the object must stay. Ozone returns HTTP 200, lists the key under Deleted, and the next HeadObject is 404.Content-MD5 is already checked on PutObject and UploadPart. A wrong value there is BadDigest and the object is not stored.
BucketEndpoint.multiDeletenever reads the header.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17835
How was this patch tested?
Added unit tests and integration test. As well as verified this manually.