Repository navigation
HDDS-17606. Disable short-circuit read of EC key - #12089
Open
Gargi-jais11 wants to merge 3 commits into
Open
Gargi-jais11 wants to merge 3 commits into
Gargi-jais11 wants to merge 3 commits into
Conversation
Contributor
Author
|
This PR is ready to be reviewed. |
Contributor
|
is there a reason for excluding EC keys from SCR? |
Contributor
Support EC is not SCR's goal at the beginning since EC cannot be benefited much as 3 replica data, due to how EC data is distributed. So disable EC key support to not expand the SCR test scope to EC at this stage which requires unnecessary resources. |
adoroszlai
requested changes
Nov 19, 2026
adoroszlai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Gargi-jais11 for the patch.
adoroszlai
approved these changes
Nov 19, 2026
adoroszlai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Gargi-jais11 for updating the patch.
Gargi-jais11
marked this pull request as ready for review
November 19, 2026 06:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Right now it is decided to disable EC key read via SCR for this phase.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17606
How was this patch tested?
added new test.