Repository navigation
Conversation
…onTest createAndDeleteTopics() wrapped createTopic/deleteTopic in catch (Exception ignored). If topic creation or deletion failed, the metrics never changed and the test could pass without exercising anything. Let the exceptions propagate so such failures fail the test.
github-actions
Bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
createAndDeleteTopics() wrapped createTopic() and deleteTopic() in
catch (Exception ignored). If one of these calls threw, the error was
silently dropped, and the test could pass even though the topics were
never created or deleted, since the metrics it monitors would simply
stay unchanged.
Changes
Let the exceptions propagate so that such failures
fail the test instead.