KAFKA-21152: LogCompactionTester should read until the end offsets instead of stopping at an empty poll - #23572
Draft
unknowntpo wants to merge 1 commit into
Draft
unknowntpo wants to merge 1 commit into
unknowntpo wants to merge 1 commit into
Conversation
…stead of stopping at an empty poll Since KAFKA-12980, poll() can return no records while the position advances, for example past records removed by compaction. So an empty poll does not mean the end of the log. Read until the position of every partition reaches the end offset, and only give up when a poll returns nothing and moves no position. Generated-by: Claude Opus 5.5
unknowntpo
force-pushed
the
log-compaction-tester-empty-poll
branch
from
September 24, 2026 05:11
604cbfb to
9d0a6fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogCompactionTest.test_log_compactionis flaky becauseLogCompactionTesterstops at the first emptypoll(). SinceKAFKA-12980,
poll()can return no records while data remains (aftercompaction, the position jumps past removed records, see KAFKA-14865),
so the tester sometimes stops early and the validation fails.
This change gets the end offsets before consuming and polls until the
position of every partition reaches its end offset. It gives up only
when a poll returns no records and moves no position.
LogCompactionTesterTestcovers an empty poll before the end offsetwith
MockConsumer.