Repository navigation
[Test] Preserve quorum during session seed fallback recovery - #18958
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18958 +/- ##
=========================================
Coverage 47.09% 47.10%
Complexity 737 737
=========================================
Files 5539 5539
Lines 405217 405217
Branches 53029 53029
=========================================
+ Hits 190854 190863 +9
+ Misses 214363 214354 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The omitted-seed recovery IT stopped two members of a three-replica Ratis cluster. This also removed the quorum needed by editions whose login path queries persisted password history, so reconnection could fail before exercising the recovery query.
Keep DN2 running while excluding it from the clients' initial snapshots and seed lists. Start both suppliers with the stale snapshot
[DN1]and seeds[DN0, DN1], recover DN0, and stop only DN1. Assert that the business connection falls back to DN0, both suppliers discover{DN0, DN2}, and their original seeds remain unchanged. Probe the recovered seed with a separate session and allow 30-second connection timeouts for login and election work.Validation
ClusterIT:SessionSeedNodeFallbackITran both methods with 0 failures, 0 errors, and 0 skips.Commands:
This PR has:
Key changed class:
SessionSeedNodeFallbackIT.