Repository navigation
Release subscription WAL buffers between prefetch rounds - #18956
Merged
jt2594838 merged 3 commits intoOct 21, 2026
Merged
Conversation
jt2594838
approved these changes
Oct 21, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The DataNode at the supplied build exhausted its 4 GiB direct-memory limit while serving
/metrics. The node had 240 subscription queues, whose paused WAL readers could each retain a direct segment buffer. This change releases those buffers between prefetch rounds while preserving reader positions and pending fragments, then reloads the current segment when a queue resumes. It also streams Prometheus snapshots as bounded 8 KiB UTF-8 chunks and reports EOF if a segment was shortened while its buffer was released.Verification
PrometheusReporterTest: 3 passed, including a response larger than 24 MiB under a 32 MiB direct-memory limit.test-compile -P with-zh-locale: passed.AstBuildercalls missingcopyToStatement()methods). The full English compile encounters the same unrelated mismatch.