Repository navigation
Conversation
|
Thanks for the PR. It is labeled If AI was used to create this PR, you must run the Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Member
|
Thanks @08abhinav. The PR Title and Pre-merge checks never started on your first push, so they show as waiting. Could you push again, rebased on the latest master or as an empty commit (git commit --allow-empty -m "ci: rerun checks"), so they run? |
08abhinav
force-pushed
the
feat/php-message-envelope-example
branch
from
November 4, 2026 04:03
7a404f7 to
fc3e9e0
Compare
hubcio
requested changes
Nov 4, 2026
hubcio
left a comment
hubcio
left a comment
Contributor
There was a problem hiding this comment.
please address the issues below.
github-actions
Bot
added
S-waiting-on-author
hubcio
previously approved these changes
Nov 4, 2026
hubcio
left a comment
hubcio
left a comment
Contributor
There was a problem hiding this comment.
no findings in the reviewed changes.
hubcio
changed the title
hubcio
changed the title
mmodzelewski
previously approved these changes
Nov 5, 2026
mmodzelewski
approved these changes
Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #4699
Rationale
The Rust, Node, Java and C# examples show the message envelope pattern, but the PHP examples only had
getting-startedandbasic. This adds the missing example without any new PHP SDK calls (parity work is tracked in #3302).What changed?
The PHP examples had no demonstration of sending several message kinds through one topic. This adds
examples/php/message-envelope/producer.phpandconsumer.php, which wrap each order payload (OrderCreated,OrderConfirmed,OrderRejected, taken from the Node example) in amessage_type+payloadJSON envelope. The consumer dispatches onmessage_typewithmatch, and logs and skips unknown or malformed messages. A "Message Envelopes" section is added toexamples/php/README.md.Local Execution
cargo buildinforeign/php, started a fresh server, ran producer then consumer: 6 messages handled, 2 of each type)message_typeand a non-JSON payload; both were logged and skippedprek)AI Usage
AI was used to assist with repository exploration, implementation, and documentation.