Repository navigation
Conversation
CI's clang-tidy step lints every file a PR touches, so these five warnings show up on any change to WholeStageResultIterator: - pass spillDir by const reference; - bind projectSource by reference instead of copying the shared_ptr; - read each partial aggregation memory limit into one optional and check it before dereferencing, instead of calling get() twice; the ratio fallback is still read only when the limit is not set; - catch and log a failure to cancel or wait for the Velox task in the destructor, which would otherwise call std::terminate.
Contributor
Author
|
cc: @zhouyuan |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
CI's clang-tidy step lints every file a PR touches, so any change to
WholeStageResultIteratorshows these five warnings (they came up on #13165):spillDiris passed by const reference instead of by value.projectSourceis bound by reference instead of copying theshared_ptr.get()twice. The ratio fallback is still read only when the limit is not set.std::terminate.Nothing else changes.
How was this patch tested?
Existing native tests in CI. clang-format-15 clean.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: IBM Bob