Skip to content

FINERACT-2301: Migrate client collateral management to CommandDispatcher#5821

Open
avivijay19 wants to merge 1 commit intoapache:developfrom
avivijay19:FINERACT-2301
Open

FINERACT-2301: Migrate client collateral management to CommandDispatcher#5821
avivijay19 wants to merge 1 commit intoapache:developfrom
avivijay19:FINERACT-2301

Conversation

@avivijay19
Copy link
Copy Markdown
Contributor

Replace untyped CommandWrapper/JsonCommand/PortfolioCommandSourceWritePlatformService with typed CommandDispatcher/Command/CommandHandler<REQ,RES> pipeline for client collateral CRUD operations.

  • Add typed request/response DTOs for create, update, delete
  • Add Command classes and CommandHandler implementations with Resilience4j retry
  • Create new ClientCollateralManagementWriteService (no JsonCommand dependency)
  • Rename ReadPlatformService to ReadService (drop PlatformSecurityContext)
  • Update API resource to use CommandDispatcher with typed returns
  • Add URL-based security matchers in SecurityConfig
  • Add Resilience4j retry config in application.properties
  • Update Spring bean wiring in CollateralManagementConfiguration
  • Delete old CommandType handlers, WritePlatformService, Swagger class, and unused request record DTOs

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Replace untyped CommandWrapper/JsonCommand/PortfolioCommandSourceWritePlatformService
with typed CommandDispatcher/Command<REQ>/CommandHandler<REQ,RES> pipeline for
client collateral CRUD operations.

- Add typed request/response DTOs for create, update, delete
- Add Command classes and CommandHandler implementations with Resilience4j retry
- Create new ClientCollateralManagementWriteService (no JsonCommand dependency)
- Rename ReadPlatformService to ReadService (drop PlatformSecurityContext)
- Update API resource to use CommandDispatcher with typed returns
- Add URL-based security matchers in SecurityConfig
- Add Resilience4j retry config in application.properties
- Update Spring bean wiring in CollateralManagementConfiguration
- Delete old CommandType handlers, WritePlatformService, Swagger class,
  and unused request record DTOs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant