FINERACT-2301: Migrate client collateral management to CommandDispatcher#5821
Open
avivijay19 wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2301: Migrate client collateral management to CommandDispatcher#5821avivijay19 wants to merge 1 commit intoapache:developfrom
avivijay19 wants to merge 1 commit intoapache:developfrom
Conversation
Replace untyped CommandWrapper/JsonCommand/PortfolioCommandSourceWritePlatformService with typed CommandDispatcher/Command<REQ>/CommandHandler<REQ,RES> pipeline for client collateral CRUD operations. - Add typed request/response DTOs for create, update, delete - Add Command classes and CommandHandler implementations with Resilience4j retry - Create new ClientCollateralManagementWriteService (no JsonCommand dependency) - Rename ReadPlatformService to ReadService (drop PlatformSecurityContext) - Update API resource to use CommandDispatcher with typed returns - Add URL-based security matchers in SecurityConfig - Add Resilience4j retry config in application.properties - Update Spring bean wiring in CollateralManagementConfiguration - Delete old CommandType handlers, WritePlatformService, Swagger class, and unused request record DTOs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace untyped CommandWrapper/JsonCommand/PortfolioCommandSourceWritePlatformService with typed CommandDispatcher/Command/CommandHandler<REQ,RES> pipeline for client collateral CRUD operations.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.